[Ocfs2-devel] [PATCH] [RFC] Mount option trap for users

[Jan Kara]

On Mon 14-09-09 12:44:05, Joel Becker wrote:
> On Mon, Sep 14, 2009 at 04:56:22PM +0200, Jan Kara wrote:
> >   OCFS2 mount option 'acl' is a small trap for users. When xattr feature
> > is not enabled and 'acl' mount option is specified, it is just silently
> > cleared during mount. IMHO that's not a good behavior - when admin requests
> > ACLs and we are not able to provide them, we should just fail the mount.
> 
> 	See
> http://www.mail-archive.com/ocfs2-devel@oss.oracle.com/msg03836.html for
> previous discussion.
  Thanks for the pointer. I didn't know about this discussion. Actually,
this is a bit different situation because you won't so easily disable the
feature on the filesystem as opposed to just booting a kernel without ACL
support.
  Also filesystems like ext3/ext4/reiserfs just silently enable the XATTR
feature when you use is for the first time and the kernel supports it (for
these filesystems XATTRs are implemented as COMPAT features). OCFS2 will
fail the syscall (and it cannot really silently enable the feature because
it is an INCOMPAT one) so that's a difference anyway... So I still think
my change makes sence.

								Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR