[Ocfs2-devel] [PATCH 2/2] ocfs2: Use MAY_CREATE in ocfs2_permission()

[Joel Becker]

On Wed, Sep 02, 2009 at 06:45:47PM -0700, Sunil Mushran wrote:
> Joel Becker wrote:
> >@@ -1108,6 +1117,10 @@ int ocfs2_permission(struct inode *inode, int mask)
> > 	ret = generic_permission(inode, mask, ocfs2_check_acl);
> > 	ocfs2_inode_unlock(inode, 0);
> >+
> >+	if (mask & MAY_CREATE)
> >+		ocfs2_unblock_signals(&oldset);
> >+
> > out:
> > 	mlog_exit(ret);
> > 	return ret;
> 
> Maybe I am missing something but shouldn't we be unblocking the signal
> after the out label.

	Yes.

Joel

-- 

"Heav'n hath no rage like love to hatred turn'd, nor Hell a fury,
 like a woman scorn'd."
        - William Congreve

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127