[Ocfs2-devel] [PATCH 13/14] ocfs2: Set xattr block entries with ocfs2_xa_set()

Tao Ma tao.ma at oracle.com
Tue Sep 1 19:50:42 PDT 2009



Joel Becker wrote:
> ocfs2_xattr_block_set() calls into ocfs2_xattr_set_entry() with just the
> HAS_XATTR flag.  Most of the machinery of ocfs2_xattr_set_entry() is
> skipped.  All that really happens other than the call to ocfs2_xa_set()
> is making sure the HAS_XATTR flag is set on the inode.
> 
> But HAS_XATTR should be set when we also set di->i_xattr_loc.  And
> that's done in ocfs2_xattr_block_set().  So let's move it there, and
it is done in ocfs2_create_xattr_block actually. ;)
Otherwise it looks good.

Regards,
Tao



More information about the Ocfs2-devel mailing list