[Ocfs2-devel] [PATCH 0/2] ocfs2: Some patches for reflink. v3
TaoMa
tao.ma at oracle.com
Thu Oct 15 15:18:49 PDT 2009
Joel Becker wrote:
> On Thu, Oct 15, 2009 at 11:06:53AM +0800, Tao Ma wrote:
>
>> This patch set integrate the fix for the bug tristan found.
>>
>
> These both look good. You know, if an inode is inline and has
> no xattrs, ie:
>
> (oi->i_dyn_flags & (OCFS2_HAS_XATTR_FL | OCFS2_HAS_INLINE_DATA_FL)) ==
> OCFS2_HAS_INLINE_DATA_FL
>
> you can just skip the refcount tree entirely. Copy the inode. Reinit
> the security if !preserve. Call it a day.
>
yeah, that is also one of the reason I moved complete_reflink out of
create_reflink_node and insert it into __ocfs2_reflink(patch 1). So if
we detect the situation you mentioned above, we will just copy the inode
and then go directly to ocfs2_complete_reflink, both create_reflink_node
and ocfs2_reflink_xattrs will be skipped. That would be quite easy.
> But this is a later optimization.
>
agree.
Regards,
Tao
More information about the Ocfs2-devel
mailing list