[Ocfs2-devel] [PATCH 1/3] ocfs2: Make ACLs always compiled into the kernel

Christoph Hellwig hch at lst.de
Thu Oct 15 06:03:44 PDT 2009


On Thu, Oct 15, 2009 at 02:54:03PM +0200, Jan Kara wrote:
> To become consistent with filesystems such as XFS or BTRFS, make posix
> ACLs always compiled into the kernel. This also reduces possibility
> of misconfiguration on admin's side.

Actually both XFS and btrfs have options for the acl code.  We don't
have options for xattrs.

These days I probably wouldn't make acls optional anymore, though -
there's very little code in the fs needed only for ACLs.

> -#ifdef CONFIG_OCFS2_FS_POSIX_ACL
>  	if (opts & OCFS2_MOUNT_POSIX_ACL)
>  		seq_printf(s, ",acl");
>  	else
>  		seq_printf(s, ",noacl");
> -#endif

It might be a good idea to always print acl here for backwards
compatiblity.




More information about the Ocfs2-devel mailing list