[Ocfs2-devel] [PATCH] [RFC] Mount option trap for users

[Jan Kara]

On Wed 14-10-09 03:03:35, Joel Becker wrote:
> On Wed, Oct 14, 2009 at 11:41:29AM +0200, Jan Kara wrote:
> > On Tue 13-10-09 17:38:59, Joel Becker wrote:
> > > 	You *are* paying attention :-)  I believe this is for hysterical
> > > raisins.  We copied ext3 on this.  I'm totally in support of ripping
> > > ACLs out of Kconfig.
> >   Yes, this would certainly simplify the situation. And looking at the
> > code, disabling CONFIG_OCFS2_POSIX_ACL does not seem to bring any
> > significant code-size or speed advantage... So I'm in favor of this.
> 
> 	So let's do this:
> 
> 1) Rip out CONFIG_OCFS2_POSIX_ACL.  The code is always built in.
> 2) Always enable acls if a filesystem has xattrs.  This is a noop if no
>    one ever calls setacl.
> 3) If a user explicitly puts -oacl on the mount command line, but the
>    filesystem doesn't have xattrs, fail the mount.  This is a safe place
>    to catch people changing kernels, as a too-old kernel driver likely
>    doesn't have xattrs anyway.
> 4) If a user explicitly puts -onoacl on the mount command line, they get
>    what they asked for.
> 
> 	This behavior matches the other 'modern' filesystems.  The only
> weirdness is in the cluster case, and the most common users will be
> using released versions with ACL support.  Anyone compiling recent
> drivers or kernels can't leave the support out.
> 	Mark, Jan?
  Yes, this looks good to me.

								Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR