[Ocfs2-devel] [PATCH] [RFC] Mount option trap for users

Jan Kara jack at suse.cz
Wed Oct 14 02:41:29 PDT 2009


On Tue 13-10-09 17:38:59, Joel Becker wrote:
> On Wed, Oct 14, 2009 at 02:27:52AM +0200, Christoph Hellwig wrote:
> > On Tue, Oct 13, 2009 at 12:46:16PM -0700, Joel Becker wrote:
> > > 	Actually, I just realized where we really differ from the other
> > > filesystems.  We're clustered, but CONFIG_OCFS2_POSIX_ACL isn't a
> > > feature flag.  We can, in theory, have two nodes.  Both have xattrs
> > > enabled, but only one has acls compiled into the kernel.  Now we're
> > > fucked.
> > > 	As far as I can tell, there is no way for the non-acl driver to
> > > notice that other nodes are using acls and reject the mount.  Thoughts?
> > 
> > So why do you allow compiling ocfs2 without ACLs at all?
> 
> 	You *are* paying attention :-)  I believe this is for hysterical
> raisins.  We copied ext3 on this.  I'm totally in support of ripping
> ACLs out of Kconfig.
  Yes, this would certainly simplify the situation. And looking at the
code, disabling CONFIG_OCFS2_POSIX_ACL does not seem to bring any
significant code-size or speed advantage... So I'm in favor of this.

								Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR



More information about the Ocfs2-devel mailing list