[Ocfs2-devel] [PATCH 02/10] ocfs2: Handle missing dlmconstants.h

Sunil Mushran sunil.mushran at oracle.com
Wed Nov 11 11:27:32 PST 2009


Joel Becker wrote:
> 	Again you're including the kapi-compat header unconditionally.
> Only include it when it is necessary.
>   

Ok.

>   
>> +#ifdef NO_DLMCONSTANTS_HEADER
>> +#include <linux/types.h>
>> +#include <linux/dlm.h>
>>     
>
> Then maybe change this to
>
> #ifndef DLM_LOCK_NL
> # include <linux/dlmconstants.h>
> #endif
>   

Not sure why we need to do this.



More information about the Ocfs2-devel mailing list