[Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume.

Sunil Mushran sunil.mushran at oracle.com
Tue May 19 14:17:22 PDT 2009


Tao Ma wrote:
> No need for nonsense "goto leave" in the end of ocfs2_mount_volume.
>
> Signed-off-by: Tao Ma <tao.ma at oracle.com>
>   

Remove redundant gotos in ocfs2_mount_volume().

Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
 


> ---
>  fs/ocfs2/super.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 79ff8d9..4601a57 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1766,13 +1766,8 @@ static int ocfs2_mount_volume(struct super_block *sb)
>  	}
>  
>  	status = ocfs2_truncate_log_init(osb);
> -	if (status < 0) {
> +	if (status < 0)
>  		mlog_errno(status);
> -		goto leave;
> -	}
> -
> -	if (ocfs2_mount_local(osb))
> -		goto leave;
>  
>  leave:
>  	if (unlock_super)
>   




More information about the Ocfs2-devel mailing list