[Ocfs2-devel] [PATCH 3/3] fs: Add the reflink(2) system call.

Al Viro viro at ZenIV.linux.org.uk
Sun May 3 04:16:04 PDT 2009


On Sun, May 03, 2009 at 03:48:49AM -0400, Christoph Hellwig wrote:
> On Sun, May 03, 2009 at 07:39:02AM +0100, Al Viro wrote:
> > Another question: do we want that to work across mounpoint boundary?
> > It's probably OK in this case, but...
> 
> I don't think so.  Allowing any link-like semantics over mount point
> boundaries will just cause problems.

Quite.  I realize that this is how vfs_link() is written, but I really
wonder if we should turn that if (foo->i_sb != bar->i_sb) into BUG_ON()
in both.  Their callers have vfsmounts and ought to do the vfsmount-level
check anyway, so running into *that* -EXDEV should be impossible.



More information about the Ocfs2-devel mailing list