[Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.

Joel Becker Joel.Becker at oracle.com
Thu Mar 19 15:06:37 PDT 2009


On Thu, Mar 19, 2009 at 02:47:44PM +0800, Wengang Wang wrote:
> yes, that's the problem.
> we'd better unify the different types(but could be another patch).
> since the on disk is u16, modifying other types to u16 is fine :)

	The -1 is a special value, and it isn't always a u16 we're
talking about.  This is both historical code and on-disk values.
INVALID_SLOT isn't 65535, it's -1.  You have to have the comparisons as
they currently stand, with the casts.

Joel

-- 

"Any man who is under 30, and is not a liberal, has not heart;
 and any man who is over 30, and is not a conservative, has no brains."
         - Sir Winston Churchill 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list