[Ocfs2-devel] [PATCH 1/2] ocfs2: reserve xattr block for directory inode in mknod

[Joel Becker]

On Wed, Mar 04, 2009 at 11:21:13AM +0800, Tiger Yang wrote:
> As we set directory inode starting with inline data,
> there is no place in inode for ACLs or security extended
> attributes entries. In this case, we have to reserve
> xattr block at the begining of mknod.
> 
> Signed-off-by: Tiger Yang <tiger.yang at oracle.com>

	This is fine, but can you update the comment above?  Something
like "If this is a new directory with inline data, we choose to reserve
the entire inline area for directory contents and force an external
xattr block."

Joel

-- 

"War doesn't determine who's right; war determines who's left."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127