[Ocfs2-devel] [PATCH] Fix compilation warning for fs/ocfs2/xattr.c
Subrata Modak
subrata at linux.vnet.ibm.com
Mon Jul 13 12:49:50 PDT 2009
Hi,
gcc 4.4.1 generates the following build warning on i386:
CC [M] fs/ocfs2/xattr.o
fs/ocfs2/xattr.c: In function âocfs2_xattr_block_getâ:
fs/ocfs2/xattr.c:1055: warning: âblock_offâ may be used uninitialized in this function
The following fix is based on a similar approach by David Howells
few days back: http://lkml.org/lkml/2009/7/9/109,
Signed-off-by: Subrata Modak<subrata at linux.vnet.ibm.com>,
---
--- a/fs/ocfs2/xattr.c 2009-06-17 17:47:21.000000000 +0530
+++ b/fs/ocfs2/xattr.c 2009-07-14 01:02:22.000000000 +0530
@@ -1052,7 +1052,8 @@ static int ocfs2_xattr_block_get(struct
struct ocfs2_xattr_block *xb;
struct ocfs2_xattr_value_root *xv;
size_t size;
- int ret = -ENODATA, name_offset, name_len, block_off, i;
+ int ret = -ENODATA, name_offset, name_len, i;
+ int uninitialized_var(block_off);
xs->bucket = ocfs2_xattr_bucket_new(inode);
if (!xs->bucket) {
---
Regards--
Subrata
More information about the Ocfs2-devel
mailing list