[Ocfs2-devel] [PATCH] Remove redundant BUG_ON in __dlm_queue_ast

Sunil Mushran sunil.mushran at oracle.com
Fri Jul 31 12:39:34 PDT 2009


Can you explain why you think it is redundant?

Goldwyn Rodrigues wrote:
>     Remove redundant BUG_ON()
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
> ---
>
> diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
> index d07ddbe..81eff8e 100644
> --- a/fs/ocfs2/dlm/dlmast.c
> +++ b/fs/ocfs2/dlm/dlmast.c
> @@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock)
>  		     lock->ast_pending, lock->ml.type);
>  		BUG();
>  	}
> -	BUG_ON(!list_empty(&lock->ast_list));
>  	if (lock->ast_pending)
>  		mlog(0, "lock has an ast getting flushed right now\n");
>  
>
>   




More information about the Ocfs2-devel mailing list