[Ocfs2-devel] [PATCH 1/1] a fix of logging return value.

[Wengang Wang]

Sunil,

in the src, I see both mlog(ML_ERROR...)(finally printk(KERN_ERR...)) 
and ocfs2_error()(finally printk(KERN_CRIT...).
could you tell me in what case one should be used?

regards,
wengang.

Wengang Wang wrote:
> Hi Sunil,
> 
> Ok. I will post patche(s) for it later.
> 
> regards,
> wengang.
> 
> Sunil Mushran wrote:
>> sob
>>
>> Hi Wengang, functions is aops.c are missing mlogs. Do you have the 
>> bandwidth to help out?
>>
>> On Jul 9, 2009, at 10:26 PM, Wengang Wang <wen.gang.wang at oracle.com> wrote:
>>
>>>    in ocfs2_file_aio_write(), log_exit() could don't log the value
>>> which is really returned. this patch fixes it.
>>>
>>> Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com>
>>> ---
>>> fs/ocfs2/file.c |    4 +++-
>>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
>>> index 62442e4..a49fa44 100644
>>> --- a/fs/ocfs2/file.c
>>> +++ b/fs/ocfs2/file.c
>>> @@ -1918,8 +1918,10 @@ out_sems:
>>>
>>>    mutex_unlock(&inode->i_mutex);
>>>
>>> +    if (written)
>>> +        ret = written;
>>>    mlog_exit(ret);
>>> -    return written ? written : ret;
>>> +    return ret;
>>> }
>>>
>>> static int ocfs2_splice_to_file(struct pipe_inode_info *pipe,
>>> -- 
>>> 1.6.2.5
>>>
> 
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel

-- 
--just begin to learn, you are never too late...