[Ocfs2-devel] [PATCH] ocfs2: return f_fsid info in ocfs2_statfs()

Mark Fasheh mfasheh at suse.com
Thu Jan 15 14:21:20 PST 2009


On Thu, Jan 15, 2009 at 11:59:36AM -0800, Sunil Mushran wrote:
> It's worse. As far as I can see, the s_uuid_hash is never populated.
> So we have two problems. The second issue is urgent as we are
> using it in xattr.

Well, mkfs.ocfs2/tunefs.ocfs2 is supposed to populate it s_uuid_hash based
on the *original* uuid of the file system. We don't dynamically calculate it
because uuid might change due to a clone operation, which would then break
the hashing of that particular file system.

Since s_uuid_hash is feature specific, I think perhaps we should just use
some part of the uuid, which is always populated. For this, I think we could
do the same as the o2cb dlm key (which has to also be pretty unique) -
crc32_le(uuid).
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list