[Ocfs2-devel] [PATCH 1/2] ocfs2: set xh_free_start when xattr header in inode/block

Joel Becker Joel.Becker at oracle.com
Thu Feb 19 09:38:43 PST 2009


On Wed, Feb 18, 2009 at 03:13:24PM +0800, Tiger Yang wrote:
> Hi, Joel and Mark,
>
> I suddenly found there might be a potential problem in this patch.
>
> If user setting EAs sometimes with .28 kernel and sometimes with .29 
> kernel, xh_free_start will go stale. And fsck will make it worse.
>
> If this really a problem I withdraw this patch but I think the second patch 
> is OK.

Tiger,
	I think you are right.  We're going to have to give up on
updating xh_free_start in inode/block.  fsck will just have to try to
verify that the entrys and values don't overlap.
	Please respin the second patch without the first, code up fsck
appropriately.

Joel

-- 

"Under capitalism, man exploits man.  Under Communism, it's just 
   the opposite."
				 - John Kenneth Galbraith

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list