[Ocfs2-devel] [PATCH 1/1] OCFS2: add IO error check in ocfs2_get_sector() -v2

Joel Becker Joel.Becker at oracle.com
Thu Feb 12 11:45:25 PST 2009


On Thu, Feb 12, 2009 at 03:47:26PM +0800, wengang wang wrote:
> checks IO error in ocfs2_get_sector().
> 
> this patch is based on 1.4 git.

	This patch is good, but definitely needs to be against mainline.

sobby

> 
> Signed-off-by: Wengang wang <wen.gang.wang at oracle.com>
> --
> Index: fs/ocfs2/super.c
> ===================================================================
> --- fs/ocfs2/super.c	(revision 128)
> +++ fs/ocfs2/super.c	(working copy)
> @@ -1203,6 +1203,12 @@ static int ocfs2_get_sector(struct super
>  	unlock_buffer(*bh);
>  	ll_rw_block(READ, 1, bh);
>  	wait_on_buffer(*bh);
> +	if (!buffer_uptodate(*bh)) {
> +		mlog_errno(-EIO);
> +		brelse(*bh);
> +		return -EIO;
> +	}
> +
>  	return 0;
>  }
>  
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel

-- 

The Graham Corollary:

	The longer a socially-moderated news website exists, the
	probability of an old Paul Graham link appearing at the top
	approaches certainty.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list