[Ocfs2-devel] [PATCH] ocfs2/trivial: Add default mask log for heartbeat.c

[Sunil Mushran]

Tao Ma wrote:
> Sunil Mushran wrote:
>> Maybe better if we changed the two mlog(0,... to mlog(ML_HEARTBEAT,...
>>
>> Now I don't know why we don't have a default mask in that file but 
>> instead
>> have distinct mlogs for HEARTBEAT and HB_BIO. One reason could have 
>> been to
>> limit the logging of hb_bio. If that is correct, then adding a 
>> default mask
>> will defeat the purpose.
> yeah, I just got that two mlog(0,...) and tried to find the default 
> mask and failed. Don't know the real reason for it. Will redo the 
> patch as you like.
>
> But the point I don't get is that why add a default mask will have an 
> effect on mlog(ML_HB_BIO,...)?

Reverse. As in, if we make that the default, then the mlogs marked hb_bio
will also print when we only want heartbeat.

Now how does that matter? Probably very little, if at all. But we will be
revisiting tracing/logging sometime next year. So I would make minimal
changes in this area right now.