[Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3

[Wengang Wang]

Hi Joel,

Joel Becker wrote:
> On Fri, Aug 28, 2009 at 03:40:21PM +0800, Wengang Wang wrote:
>> Ok. Then I will pick up the mlog_error()s and mlog(ERR...)s and re-post 
>> later...
> 
> 	Sounds good.
> 	If the area of logging interests you, would you take a stab at
> adding tracepoints to ocfs2?  Mainline has a generic infrastructure for
> "tracepoints" that can be dropped in nicely in code and don't have to be
> printk()d.  Debugfs files can be used to enable them or disable them as
> a group or individually, so we could even just say "only trace
> ocfs2_new_inode".  The tracing can be filtered by pid or by function,
> too.
> 	See Documentation/trace/tracepoints.txt for a little overview,
> but really look at include/trace/events/ext4.h and the associated calls
> in fs/ext4.  I'd love to see a small include/trace/events/ocfs2.h to
> start.  Maybe just give aio_write and aio_read callers or something.
> Just so there is a nice example for others to follow.
> include/trace/events/o2dlm.h would be cool too, we could trace locking
> calls.
> 	Feel free to ask me any questions.
> 

That sounds very interesting to me!
and will ask you questions inside ocfs2 and outside it :D

regards,
wengang.