[Ocfs2-devel] [PATCH] ocfs2: adds mlogs to aops.c -V3
Wengang Wang
wen.gang.wang at oracle.com
Thu Aug 27 19:12:45 PDT 2009
Hi Joel,
in fact, I had ever hit case that ocfs2 returns EIO, but even allowing
ENTRY/EXIT, there is no log indicating that.. the bug number is 8627756.
So I think we'd better add the logs to such functions. and added them
for the functions in aops.c(seems that Sunil wants to add logs to that
file)...
and for the patch its self, I think the log contents are for developers
to check(not for customer to view), so we can know what are printed by
checking the src... so I am printing some parameters without pointing
out what they are.
regards,
wengang.
Joel Becker wrote:
> On Fri, Aug 14, 2009 at 02:02:39PM +0800, Wengang Wang wrote:
>> this patch adds some mlogs to apos.c helping tracing and narrowing down bugs.
>
> Wengang,
> Have these traces been of use to you, or are you just adding
> some entry/exit traces because you see functions without them?
>
> Joel
>
More information about the Ocfs2-devel
mailing list