[Ocfs2-devel] Why do we read the blocks in __ocfs2_xxattr_set_value_outside()?

Joel Becker Joel.Becker at oracle.com
Tue Aug 11 15:09:15 PDT 2009


	In __ocfs2_xattr_set_value_outside(), we walk each block of the
xattr value and read it before we copy the new data on top and dirty it.
Why are we reading the block from disk if we're just overwriting it?
Would't "sb_getblk(); ocfs2_set_buffer_uptodate()" work better?

Joel

-- 

"This is the end, beautiful friend.
 This is the end, my only friend the end
 Of our elaborate plans, the end
 Of everything that stands, the end
 No safety or surprise, the end
 I'll never look into your eyes again."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list