[Ocfs2-devel] [PATCH] ocfs2: Fix a missing credit when deleting from indexed directories.

Mark Fasheh mfasheh at suse.com
Thu Apr 30 11:00:03 PDT 2009


On Wed, Apr 29, 2009 at 06:04:51PM -0700, Joel Becker wrote:
> The ocfs2 directory index updates two blocks when we remove an entry -
> the dx root and the dx leaf.  OCFS2_DELETE_INODE_CREDITS was only
> accounting for the dx leaf.  This shows up when ocfs2_delete_inode()
> runs out of credits in jbd2_journal_dirty_metadata() at
> "J_ASSERT_JH(jh, handle->h_buffer_credits > 0);".
> 
> The test that caught this was running dirop_file_racer from the
> ocfs2-test suite with a 250-character filename PREFIX.  Run on a 512B
> blocksize, it forces the orphan dir index to grow large enough to
> trigger.
> 
> Signed-off-by: Joel Becker <joel.becker at oracle.com>

Acked-by: Mark Fasheh <mark.fasheh at oracle.com>

--
Mark Fasheh



More information about the Ocfs2-devel mailing list