[Ocfs2-devel] [PATCH 1/1] ocfs2: Add missing iput() during error handling in ocfs2_dentry_attach_lock()

Mark Fasheh mfasheh at suse.com
Tue Apr 21 15:00:44 PDT 2009


On Mon, Apr 20, 2009 at 09:34:18PM -0700, Sunil Mushran wrote:
> In ocfs2_dentry_attach_lock(), if unable to get the dentry lock(), we need to
> call iput(inode) because a failure here means no d_instantiate(), which means
> the normally matching iput() will not be called during dput(dentry).
> 
> This patch fixes the oops that accompanies the following message:
> (3996,1):dlm_empty_lockres:2708 ERROR: lockres W00000000000000000a1046b06a4382 still has local locks!
> kernel BUG in dlm_empty_lockres at /rpmbuild/smushran/BUILD/ocfs2-1.4.2/fs/ocfs2/dlm/dlmmaster.c:2709!
> 
> Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
Acked-by: Mark Fasheh <mfasheh at suse.com>
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list