[Ocfs2-devel] [PATCH 2/3] ocfs2: Add security xattr support in ocfs2

[Mark Fasheh]

On Wed, Sep 24, 2008 at 03:44:18PM +0800, Tiger Yang wrote:
> Mark Fasheh wrote:
> >Oh, almost missed this actually. Isn't it customary to allow the user to
> >select whether to compile in support for security attributes, or acls? You
> >can pretty much copy the code from any other file system really.
> OK. I will refer to others.
> 
> One more question, They also allow user to select whether support EA,
> in ocfs2, do we need this option in Kconfig? or we support EA by default?

Hmm... Do you know why they allow EA's to be compiled optionally? Maybe we
should do the same. I don't have any strong opinions one way or the other
though.


> >Also, would you mind rebasing these against the latest xattrs branch in
> >ocfs2.git? The only change was that I removed the code in '#ifdef
> >CONFIG_OCFS2_FS_SECURITY' and '#ifdef CONFIG_OCFS2_FS_ACL' because we
> >weren't ever defining those yet. Obviously, you get to add them back now  
> >:)
> no problem. I will rebase the branch and generate all the patches.

Thanks, I appreciate this.
	--Mark

--
Mark Fasheh