[Ocfs2-devel] [PATCH 29/29] ocfs2: Enable quota accounting on mount, disable on umount

[Joel Becker]

On Sat, Oct 25, 2008 at 12:08:22AM +0200, Jan Kara wrote:
> Enable quota usage tracking on mount and disable it on umount. Also
> add support for quota on and quota off quotactls and usrquota and
> grpquota mount options.
> 

<snip>

> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 92539fe..bddc210 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -780,6 +950,23 @@ static int ocfs2_fill_super(struct super_block *sb, void *data, int silent)
>  	atomic_set(&osb->vol_state, VOLUME_MOUNTED);
>  	wake_up(&osb->osb_mount_event);
>  
> +	/* Now we can initialize quotas because we can afford to wait
> +	 * for cluster locks recovery now. That also means that truncation
> +	 * log recovery can happen but that waits for proper quota setup */
> +	if (!(sb->s_flags & MS_RDONLY)) {
> +		status = ocfs2_enable_quotas(osb);
> +		if (status < 0) {
> +			mlog_errno(status);
> +			goto read_super_error;
> +		}
> +	}
> +
> +	ocfs2_complete_quota_recovery(osb);
> +
> +	/* Now we wake up again for processes waiting for quotas */
> +	atomic_set(&osb->vol_state, VOLUME_MOUNTED_QUOTAS);
> +	wake_up(&osb->osb_mount_event);
> +
>  	mlog_exit(status);
>  	return status;
>  

	This hunk still has the bug where you are jumping to
read_super_error after setting sb->s_root.  I'm guessing you have that
fixed on your machine?

Joel

-- 

Life's Little Instruction Book #80

	"Slow dance"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127