[Ocfs2-devel] [PATCH] ocfs2: Fix check of return value of ocfs2_start_trans()

Joel Becker Joel.Becker at oracle.com
Fri Oct 24 14:41:42 PDT 2008


On Tue, Oct 21, 2008 at 01:26:18PM -0700, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:51PM +0200, Jan Kara wrote:
> > On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM).
> > Thus checks for !handle are wrong. Fix them to use IS_ERR().
> > 
> > Signed-off-by: Jan Kara <jack at suse.cz>
> Signed-off-by: Joel Becker <joel.becker at oracle.com>
> 
> This should go upstream.  There are two more in xattr.c (not in the
> sources Jan had).

	This is now in my xattr-28 branch, along with Tao's version for
xattr.c

Joel

-- 

	Pitchers and catchers report.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list