[Ocfs2-devel] [PATCH 0/6] Refactor ocfs2_read_blocks()

Joel Becker joel.becker at oracle.com
Thu Oct 9 17:20:28 PDT 2008


ocfs2_read_blocks() is a complex kitchen sink for almost all block
reading in ocfs2.  Before I add logic to let callers key on whether a
block was in cache or not, Mark and I decided it could use some cleaning
up.

First, synchronous reads are moved to a separate function.  The main
logic of ocfs2_read_blocks() is really about cached reads.  Next, we can
make the inode a requirement and simplify the function call.  After
that, ocfs2_read_block() becomes an always-cached operation.  We move
ocfs2_bread() to dir.c where it is used and make sure dir.c isn't using
naked bh functions.  Finally, we make cached I/O the common case.

Joel





More information about the Ocfs2-devel mailing list