[Ocfs2-devel] [PATCH 13/39] ocfs2: Add extended attribute support

[Tao Ma]

Mark Fasheh wrote:
> On Thu, Oct 02, 2008 at 10:16:44AM +0200, Christoph Hellwig wrote:
>> On Wed, Sep 24, 2008 at 03:00:54PM -0700, Mark Fasheh wrote:
>>>  	xattr.o			\
>>> +	xattr_user.o		\
>>> +	xattr_trusted.o
>> Please don't split this up, it's always been a really stupid idea in
>> extN.  The only difference between secure, trusted and user attrs is
>> that they go into a different namespace bit (and have different
>> permission checking, but that's handled in the VFS).  I have some
>> upcoming patches to store a fs private flag in struct xattr_handler
>> so that even those flags wrappers can go away, and each of the
>> namespaces will just be five lines of code for the xattr_handler
>> declaration.
> 
> Ok. The following patch (in ocfs2.git now) removes those two files, and puts
> the code for user and trusted xattrs at the bottom of xattr.c. Is that
> mainly what you were getting at here?
> 
> 
>>> +static inline struct xattr_handler *ocfs2_xattr_handler(int name_index)
>>> +{
>>> +	struct xattr_handler *handler = NULL;
>>> +
>>> +	if (name_index > 0 && name_index < OCFS2_XATTR_MAX)
>>> +		handler = ocfs2_xattr_handler_map[name_index];
>>> +
>>> +	return handler;
>>> +}
>> You seem to need the handler mostly for getting back to the prefix
>> from the handler.  This is a pretty clear indicator that you don't
>> want to use the xattr_handler splitting but deal with the whole
>> attr name.  Take a look at the btrfs code after my recent xattr changes
>> on how to handle this more nicely.
> 
> Tao, Can you look into this?
> 
ok, I will look at btrfs to see how it handle this.

Regards,
Tao