[Ocfs2-devel] [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees

Mark Fasheh mfasheh at suse.com
Tue Oct 7 14:19:12 PDT 2008


On Wed, Oct 01, 2008 at 11:12:05PM -0700, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 15:00:52 -0700 Mark Fasheh <mfasheh at suse.com> wrote:
> > +	if (eb_bh)
> > +		brelse(eb_bh);
> 
> brelse(0) is legal.  Please do an fs-wide review for this.

Ok, I'll queue that up. I'll watch to make sure that new patches from here
on won't do this.


> It shouldn't affect code generation because brelse() is inlined.

Fair enough, thanks.
	--Mark


--
Mark Fasheh



More information about the Ocfs2-devel mailing list