[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Andrew Beekhof]

On Nov 19, 2008, at 12:03 AM, Joel Becker wrote:

> On Tue, Nov 18, 2008 at 11:18:38AM +0100, Andrew Beekhof wrote:
>> Fix a number of LSB compliance issues reported by rpmlint regarding
>> ocfs2 init scripts
>>
>> Signed-off-by: Andrew Beekhof <abeekhof at suse.de>
>>
>> --- upstream/vendor/common/o2cb.init.sh	2008-09-11 16:51:11.000000000
>> +0200
>> +++ dev/vendor/common/o2cb.init.sh	2008-10-23 14:36:49.000000000  
>> +0200
>> @@ -8,7 +8,8 @@
>>  # Provides: o2cb
>>  # Required-Start: $network
>>  # Should-Start:
>> -# Required-Stop:
>> +# Should-Stop:
>> +# Required-Stop: $null
>
> 	Really, rpmlint requires everyone to know some magic $null?  Who
> the heck thought that one up?

Someone with too much time on their hands

> Is it portable to all distros?

I'm assuming yes based on rpmlint being an external project and that  
its vaguely consistent with $network.
But I don't have any other distros to test on - nor the first clue on  
how to check :-/