[Ocfs2-devel] [PATCH 01/15] ocfs2/xattr: Only extend xattr bucket in need.

[Tao Ma]

Mark Fasheh wrote:
> On Thu, Oct 30, 2008 at 01:42:11PM +0800, Tao Ma wrote:
>> When the first block of a bucket is filled up with xattr
>> entries, we normally extend the bucket. But if we are
>> just replace one xattr with small length, we don't need
>> to extend it. This is important since we will calculate
>> what we need before the transaction and in this situation
>> no resources will be allocated.
> 
> Ok, looks good. Am I correct in thinking that this is a fix which should go
> upstream before 2.6.28 is out?
en, this should not be called a bug fix. Maybe an improvement. In old 
implementation, we extend the bucket with a less restriction. And since 
we allocate resource in ocfs2_extend_xattr_bucket, it will not cause a 
problem. But if we want to merge the transactions into one, I calculate 
the resource needed in a more strict way, so it is a problem at that time.

anyway, you can push it before 2.6.28 as you wish.

Regards,
Tao