[Ocfs2-devel] [PATCH 7/8] ocfs2: Add extended attributes support. v1

[Tao Ma]

Hi Mark,
	Yes, this is also a problem in xattr bucket. Tiger and I both inserted 
a zeroed tree root as xattr's value and then extend the root.

The [PATCH 13/15] also has the same problem. I will revise it in the 
next round.

Regards,
Tao

Mark Fasheh wrote:
> On Fri, Jun 27, 2008 at 03:49:45PM +0800, Tiger Yang wrote:
>> I split setting long value operation into two parts. First insert tree 
>> root in local, if succeed then insert long value into B tree based on 
>> that tree root. If hit problem in second step, we could only get that 
>> junk tree root. This is harmless for system. but is it acceptable?
> 
> If the junk root is ignored, and eventually overwritten as more ea's get
> inserted then I don't think you need to do any more.
> 
> If the junk root stays in the block and occupies space that would otherwise
> be used, then we probably need to handle this.. I imagine a clever user
> could DOS the xattr space by making large ones when the system is low on
> free space...
> 	--Mark
> 
> --
> Mark Fasheh
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel