[Ocfs2-devel] [PATCH 6/8] Add extent tree operation for xattr value.v1

Mark Fasheh mfasheh at suse.com
Thu Jun 12 19:56:22 PDT 2008


On Fri, Jun 13, 2008 at 09:48:24AM +0800, Tao Ma wrote:
> >Hmm, at this point, wouldn't it make sense to have a couple high-level
> >"ocfs2_foo_insert_extent" functions whcih build up anm ocfs2_extent_tree 
> >and
> >then pass it down to the common ocfs2_insert_extent?
> Why do we need that? Just to reduce the parameter to one 
> "ocfs2_extent_tree *"? ;) Any other benefit?

No, that's mostly what I was concerned with. Well, that and type-checking -
we don't have to have a void * in ocfs2_insert_extent any more.
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list