[Ocfs2-devel] [PATCH 3/8] Make ocfs2_lock_allocators generic for extent allocation.v1

Tao Ma tao.ma at oracle.com
Wed Jun 11 18:40:32 PDT 2008


Hi Mark,
	Thanks for the review.
	I will modify it according to your suggestions.

Mark Fasheh wrote:
> The rest of this looks good. It's a big patch, but it looks good :) The only
> conern I have isn't really with your code per se, but with layout of our
> source files. Alloc.c keeps growing... and growing... and growing... At some
> point it might be worth our while to split things out at least so that we
> have a 'core btree operations' file.
Yes, now alloc.c have more than 6000 lines. And maybe a new file name 
btree.c can be split out from this file that will do the real work of 
btree operation since with my patch, btree now isn't used by inode only. ;)
I will handle this after the xattr patch is committed. Thanks.

Regards,
Tao



More information about the Ocfs2-devel mailing list