[Ocfs2-devel] [PATCH 2/2] ocfs2-tools: Add extended attribute support in fsck.ocfs2

Tao Ma tao.ma at oracle.com
Fri Jul 25 02:08:03 PDT 2008



Tiger Yang wrote:
> 
> Tao Ma wrote:
> 
>>> +static inline int ocfs2_xattr_extent_recs_per_inode(int blocksize)
>>> +{
>>> +    int size;
>>> +
>>> +    size = blocksize - offsetof(struct ocfs2_xattr_block,
>>> +                    xb_attrs.xb_root.xt_list.l_recs);
>>> +
>>> +    return (size / sizeof(struct ocfs2_extent_rec));
>>> +}
>> I remember with 512, there is no xattr in inode.
> 
> This function only used in index block, it's not for inode block.
So could you please rename it as it isn't concerned with inode?

btw, next time please send your patch to ocfs2-tools-devel since it is 
tools' patches.

Regards,
Tao



More information about the Ocfs2-devel mailing list