[Ocfs2-devel] [PATCH 08/15] ocfs2: Add extended attribute support v2

[Mark Fasheh]

On Thu, Jul 17, 2008 at 05:34:01PM +0800, Tiger Yang wrote:
> >Btw, neither this, nor any of the other code seems to take symlinks into
> >account. As far as I can tell, it's valid to set xattrs on a symlink. Is
> >this correct? If so, we need to handle fast symlinks and also symlinks with
> >extents. Though I suppose symlinks using extents probably don't need any
> >extra work since they otherwise look like regular files.
> 
> Could I do not put xattr inline when I found its a fast symlink? This 
> could make the question simple.

Most of our symlinks are fast symlinks, so I don't think it'd be a good idea
to skip inline xattrs on them.

What's the problem though? From your code, it seemed like fast symlinks
would be pretty easy to take care of... Keep in mind by the way, that once
created, the contents of a symlink never change. So it's not like you'll
have to update the actual symlink code very much.
	--Mark

--
Mark Fasheh