[Ocfs2-devel] Re: [PATCH 06/30] ocfs2: Include do_sync_mapping_range() from mainline

[Joel Becker]

On Mon, Dec 31, 2007 at 02:23:58PM -0800, Sunil Mushran wrote:
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index 4791433..fc7ee22 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -23,11 +23,13 @@
>   * Boston, MA 021110-1307, USA.
>   */
>  
> +#ifndef NO_SYNC_MAPPING_RANGE
>  #include <linux/fs.h>
>  #include <linux/types.h>
>  #include <linux/slab.h>
>  #include <linux/highmem.h>
>  #include <linux/swap.h>
> +#endif

	Why are you adding these #ifdefs?  The headers can be included
twice safely, they prevent re-inclusion - or at least they should.

Joel

-- 

Life's Little Instruction Book #356

	"Be there when people need you."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127