[Ocfs2-devel] [PATCH 1/1] ocfs2_net: Debug interface added to o2net

[Joel Becker]

On Tue, Feb 26, 2008 at 07:08:20PM -0800, Sunil Mushran wrote:
> This patch is a forward port of net_proc.c in OCFS2 1.2. The difference
> here is that the debugging funtionality is exposed via debugfs.

	The code looks good and sign-offable, but you need to either
wrap it in CONFIG_DEBUG_FS or make CONFIG_OCFS2 depend on
CONFIG_DEBUG_FS.  In fact, I think we have the problem already with
ocfs2_dlm_init_debug().

Joel


-- 

"When I am working on a problem I never think about beauty. I
 only think about how to solve the problem. But when I have finished, if
 the solution is not beautiful, I know it is wrong."
         - Buckminster Fuller

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127