[Ocfs2-devel] [PATCH 09/10] ocfs2: Add an insertion check to ocfs2_extent_tree_operations.

[Mark Fasheh]

On Thu, Aug 21, 2008 at 04:25:40PM -0700, Joel Becker wrote:
> > Is there a reason why you changed the way we initialize "rec" for this
> > patch? I guess the end result is the same - specifically, I want to be 100%
> > certain that rec.e_reserved1 gets zero'd. Still though, I think the flow we
> > had before was better.
> 
> 	Well, the naked memset() is ugly (IMHO) when the initializer
> works (an initializer ensures that all non-initialized fields are zero).
> However, it didn't work quite like I expected, since gcc couldn't handle
> the anonymous union in the initializer.  I'll revert it back to the old
> way.

Thanks. Too bad about gcc though :(
	--Mark

--
Mark Fasheh