[Ocfs2-devel] [PATCH 07/10] ocfs2: Determine an extent tree's max_leaf_clusters in an et_op.

[Joel Becker]

On Thu, Aug 21, 2008 at 03:25:04PM -0700, Mark Fasheh wrote:
> On Wed, Aug 20, 2008 at 07:48:22PM -0700, Joel Becker wrote:
> > --- a/fs/ocfs2/alloc.c
> > +++ b/fs/ocfs2/alloc.c
> > @@ -76,6 +76,8 @@ struct ocfs2_extent_tree_operations {
> >  	/* These are internal to ocfs2_extent_tree and don't have
> >  	 * accessor functions */
> >  	void (*eo_fill_root_el)(struct ocfs2_extent_tree *et);
> 
> A comment here, noting that it's optional and what the expected behavior is
> if it isn't set would be nice. Otherwise, this patch looks great.

	eo_fill_root_el() is required, but really I think the entire set
of ops should be commented.  I only didn't because the initial set
wasn't.  I was wrong, and probably should have even specified the
comments in the original review of Tao's patches.

Joel

-- 

"I'm drifting and drifting
 Just like a ship out on the sea.
 Cause I ain't got nobody, baby,
 In this world to care for me."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127