[Ocfs2-devel] [PATCH 09/10] ocfs2: Add an insertion check to ocfs2_extent_tree_operations.
TaoMa
tao.ma at oracle.com
Wed Aug 20 21:29:01 PDT 2008
Joel Becker wrote:
> The op eo_sanity_check() was really a check on remove_right_path().
> Let's call it eo_remove_check(). Let's add an eo_insert_check() that
> can be called from ocfs2_insert_extent().
>
eo_sanity_check is used to check inode, and I don't see there is any
hint of remove_right_path in this function although it is now only used
in ocfs2_remove_rightmost_path. And I have said in the previous
e-mail,it can be used in ocfs2_num_free_extents.
So I'd like to reserve the name and your add for insert_check is OK or
it can be moved to ocfs2_*_insert_extent.
Regards,
Tao
More information about the Ocfs2-devel
mailing list