[Ocfs2-devel] [PATCH 05/15] ocfs2: Pass raw u64 to filldir

[Joel Becker]

On Mon, Sep 10, 2007 at 05:30:26PM -0700, Mark Fasheh wrote:
> filldir_t can take this, so don't turn de->inode into a 32 bit value. Right
> now this doesn't make a difference since no ocfs2 inodes overflow that, but
> it could be a nasty surprise later on if some kernel code is calling
> ocfs2_dir_foreach_blk() and expecting real inode numbers back...

	How come we don't have inodes overflowing 32bits?  Is this a
limit imposed elsewhere?  Refresh my (swiss cheese) memory :-)
	I actually think that the -EOVERFLOW from filldir(7) is better
than our truncated ino, so I still say

Signed-off-by: Joel Becker <joel.becker at oracle.com>

-- 

Viro's Razor:
	Any race condition, no matter how unlikely, will occur just
	often enough to bite you.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127