[Ocfs2-devel] [PATCH 02/15] ocfs2: Small refactor of truncate zeroing code

Joel Becker Joel.Becker at oracle.com
Thu Sep 20 11:27:02 PDT 2007


On Fri, Sep 07, 2007 at 02:20:45PM -0700, Mark Fasheh wrote:
> We'll want to reuse most of this when pushing inline data back out to an
> extent. Keeping this part as a seperate patch helps to keep the upcoming
> changes for write support uncluttered.
> 
> The core portion of ocfs2_zero_cluster_pages() responsible for making sure a
> page is mapped and properly dirtied is abstracted out into it's own
> function, ocfs2_map_and_dirty_page(). Actual functionality doesn't change,
> though zeroing becomes optional.
> 
> We also turn part of ocfs2_free_write_ctxt() into  a common function for
> unlocking and freeing a page array. This operation is very common (and
> uniform) for Ocfs2 cluster sizes greater than page size, so it makes sense
> to keep the code in one place.
> 
> Signed-off-by: Mark Fasheh <mark.fasheh at oracle.com>

Signed-off-by: Joel Becker <joel.becker at oracle.com>

-- 

"Where are my angels?
 Where's my golden one?
 And where is my hope
 Now that my heroes are gone?"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list