[Ocfs2-devel] cluster/heartbeat.c::compute_max_sectors is invalid.

[Mark Fasheh]

On Wed, Sep 13, 2006 at 10:44:42AM +0200, Mathieu Avila wrote:
> A proposal patch (against the 2.6.17.11 vanilla kernel) for this is
> attached. It works for me, and shouldn't break any existing device.
Ok, that patch looks good - I've put it in my 2.6.19 queue.


> And i still think that it is a bad idea to try figuring out how many
> BIOs are needed, because it really depends on the underlying
> architecture of the device. Although it might work on most hardware,
> some strange one might break one day...
Well, I'm pretty sure some other software uses that approach, but that might
just mean other software might have similar problems :)

So yeah. I don't reallly have any qualms changing ocfs2 heartbeat to a more
"natural" usage of the bio API.


Thanks!
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com