[Ocfs2-devel] [patch 3/3] ocfs2-timeout-protocol.patch

[Mark Fasheh]

Hi Andrew,
	This patch is much better. The new comments and the removal of
prototype cleanups made it a lot easier to read through too.

I have just one comment below :)

On Thu, Nov 30, 2006 at 07:11:31PM +0100, abeekhof at suse.de wrote:

> Index: fs/ocfs2/cluster/tcp.c
> ===================================================================
> --- fs/ocfs2/cluster/tcp.c.orig	2006-11-30 18:53:24.000000000 +0100
> +++ fs/ocfs2/cluster/tcp.c	2006-11-30 19:02:30.000000000 +0100
> @@ -380,6 +380,13 @@ static void o2net_sc_cancel_delayed_work
>  		sc_put(sc);
>  }
>  
> +atomic_t o2net_connected_peers = ATOMIC_INIT(0);
> +
> +int o2net_num_connected_peers(void)
> +{
> +	return o2net_connected_peers.counter;
> +}
I think maybe you missed the definition of 'atomic_read', which needs to be
used instead of bare access to the counter value. I see a couple places
where you access the counter below - those need to be updated as well.

Thanks,
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com