[Ocfs2-devel] [patch 3/3] OCFS2 Configurable timeouts - Protocol changes

[Mark Fasheh]

On Sat, Nov 18, 2006 at 08:36:03AM +0100, abeekhof at suse.de wrote:
> The addition of two dummy fields is a temporary measure to 
>    satisfy the logic in o2net_check_handshake() and will be
>    rectified in a future version of this patch
Maybe I'm being silly, but I just can't seem to figure out precisely which
logic you're talking about here. Can you elaborate, please?


> +static void o2net_initialize_handshake(void)
> +{
> +	static int initialized = 0;
> +	if(initialized)
> +		return;
> +
> +	initialized = 1;
> +	o2net_hand->o2net_idle_timeout_ms = cpu_to_be32(
> +		o2net_idle_timeout(NULL));
> +	o2net_hand->o2net_keepalive_delay_ms = cpu_to_be32(
> +		o2net_keepalive_delay(NULL));
> +	o2net_hand->o2net_reconnect_delay_ms = cpu_to_be32(
> +		o2net_reconnect_delay(NULL));
> +}
We should populate o2hb_heartbeat_timeout_ms here. Checking against it in
o2net_check_handshake() would also be good.

Thanks,
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com