[Ocfs2-devel] [tytso@thunk.org: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private]

Zach Brown zach.brown at oracle.com
Mon Jun 19 14:39:26 CDT 2006


> I note that OCFS2 uses generic_ip only one place, in debug code:
> 
> ocfs2_dlm_debug_open():
> 	1998         osb = (struct ocfs2_super *) inode->u.generic_ip;
> 
> However, we never set it!  This leads me to believe this is stale code.

That's the dlm debugging fops getting the osb off of the debugfs inode's
generic_ip which was set with debugfs_create_file().

- z



More information about the Ocfs2-devel mailing list