[Ocfs2-devel] Re: [RFC] [PATCH] OCFS2

Mark Fasheh mark.fasheh at oracle.com
Thu May 19 01:54:05 CDT 2005


On Thu, May 19, 2005 at 02:30:23AM -0400, Daniel Phillips wrote:
> Zero terminated strings for lock names is bad taste.  It generates a bunch of 
> useless strlen executions and you force an ascii namespace for no apparent 
> reason.  Add a 9th parameter, namelen, to the lock call maybe?
Or perhaps pass in a qstr? Anyway I have to agree. That shouldn't be
difficult to fix up.
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com



More information about the Ocfs2-devel mailing list