[Ocfs2-devel] Re: [RFC] [PATCH] OCFS2

[Mark Fasheh]

Hi James,

Thanks for looking over this.

On Thu, Jun 23, 2005 at 02:03:35PM -0400, James Morris wrote:
> The masklog code looks potentially useful outside of ocfs2, as a general 
> kernel facility.  Any chance of splitting it out?
Absolutely. We've found that stuff invaluable in debugging issues for a
while now, and as far as I recall, Zach wrote it with the idea that it could
be useful to other folks too. I think the only issue to resolve there would
be how other subsystems reserve a debugging bit...

> Quibbles:
> 
> - A lot of the macros should probably be replaced with static inlines, 
> like OCFS2_IS_VALID_DINODE.
> 
> - Approx. 80 typedefs.  ouch.
Heh, we're slowly removing those :)
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com